Conversation
|
What is the status of this PR? |
|
The current status is CI failure left. As far as I recall, I approved this PR waiting for the tests to finish, and then some of them failed. The failed actions cannot be rerun by now, so you'll have to push again to trigger a new run. I guess Ruby 2.4 & 2.5 on macOS may be removed if they still fail again because those versions are too old. |
The errors on Ruby 2.4 & 2.5 on macOS have already been fixed in the following PR: It seems that rebasing this branch should resolve the errors. @ishikawa999 Could you please rebase it? ReferenceI tried rebasing on my forked repository, and the CI passed: (Resolved by test-unit-ruby-core gem v1.0.10) However, since the |
96b3ecd to
c96dbad
Compare
|
Thanks for the review, and sorry I missed your feedback earlier. |
|
@ishikawa999 Thank you for your response. The CI for @knu @hsbt The CI will pass, so could you please check it?
|
|
@hsbt Thank you for merging. |
This pull request will fix issue #60.
Fix to use the
addrvariable that exists instead of the non-existent@addr.